Stuart McCulloch (JIRA) wrote:
     [ 
https://issues.apache.org/jira/browse/FELIX-263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stuart McCulloch updated FELIX-263:
-----------------------------------

    Attachment: FELIX-263-build.patch

As we're already using ant to build this project in phases, it makes sense to 
build the plugins in a 'bootstrap' phase. Most of the plugin errors with 2.0.5 
appear to occur when you try to build and use a plugin in the same build 
process.

By separating out building of felix plugins, we can avoid these (and future) 
problems.

The attached patch modifies the top-level pom and build.xml so that the plugins 
get built first.

( BTW, is there a reason why the ipojo.plugin is in the top-level directory? 
shouldn't it be under tools/maven2? )

Personally, I am not a fan of the "tools" directory. Unfortunately, we have never really settled on a definitive approach to organizing the repo. Initially it was somewhat hierarchical, then we decided to go flat, but not everything was flattened, then there was a potential backlash against flat with a move back to hierarchical.

So, in short, it is really somewhat of a mess.

One issue was the long file names, which we still haven't fully fixed yet either, but most project directories were renamed from fully qualified package roots to just their unique portion.

Ultimately, I prefer short directory names (i.e., the unique portion of the fully qualified package name). However, I don't have a good argument either way for hierarchical versus flat.

The main value I can see for a hierarchical structure is that it groups subprojects better. For example, iPOJO could be like this:

   trunk/
      ipojo
         arch/
         ipojo/
         metadata/
         plugin/

Likewise for UPnP MOSGi, and Event Admin, all of which have multiple directories currently in the trunk. Something like this is already done for "examples".

As for the other plugins, I think they should be moved up to the trunk, since they are subprojects and should be at the same level as any other subproject. I also wonder if we should not think about changing some of the names of the plugins, since "maven-bundle-plugin" creates long goal names...

-> richard

p.s. Regarding your patch, if it fixes the problem for now, then I can apply it, but our goal is to eliminate Ant completely once we get the Maven bug fixed that is affecting us. So, this would not be the solution for the future, only for the now.

Reply via email to