On Tue, Nov 26, 2013 at 09:37:01AM +0000, Garth N. Wells wrote: > On 2013-11-26 09:22, Marco Morandini wrote: > >On 11/26/2013 10:22 AM, Garth N. Wells wrote: > >>A fix for the STL std::nth_element bug in gcc 4.8.1 has been released > >>for Ubuntu 13.10 as an update: > >> > >> https://bugs.launchpad.net/ubuntu/+source/gcc-4.8/+bug/1246802 > >> > >>I suggest that we now remove the ifdefs for using boost::nth_element. > >>The change was not made in a separate branch, so undoing it will > >>require > >>some digging. Anders: will you undo the change? > >> > > > >Don't assume that everyone out there is using Ubuntu. > >You could consider adding a check at configure time > >to detect the gcc bug. > > > > 1. Which distributions are using unpatched GCC 4.8.1?
I don't know, but there will be many (?) users of Ubuntu who have not yet upgraded GCC. > 2. The proposal to check for gcc bugs is not, in general, sensible. > GCC has had many bugs that are fixed in subsequent releases. We have > never checked for these. Agree, but this is different since we happen to know about a specific bug that affects us. > 3. std::nth_element is used in DOLFIN dependencies, and we cannot > fix this, so using boost::nth_element is not general fix. Agree. -- Anders _______________________________________________ fenics mailing list [email protected] http://fenicsproject.org/mailman/listinfo/fenics
