On Tue, Nov 4, 2014 at 12:02 PM, Garth N. Wells <[email protected]> wrote:
> > On Tue, 4 Nov, 2014 at 10:49 AM, Johan Hake <[email protected]> wrote: > >> Hello! >> >> With the exposure of the MPI_COMM we no longer have MPI aware logging >> system. It would be nice to get that back again. We probably have had this >> discussion previously but it would be nice to reiterate it here. >> > > I made a start on this a while back, but got stuck in the ellipses syntax > that caused me some problems when overloading the logging functions. > > >> I suggest that we make it possible to set an MPI_COMM to the main Logger, >> so that we keep the interface to all log functions as is. >> >> void set_log_mpi_comm(MPI_COMM comm); >> > > We should pass the communicator to the log functions. Because attaching a communicator to the Logger is evil or just bad/sub-optimal design? Then we use the MPI_COMM of the Logger to determine what process the log >> message should be visible on. By default it is set by MPI_COMM_WORLD. >> >> I am also not happy with the parameter name: >> >> "std_out_all_processes" >> >> I think it is more useful to explicitly use: >> >> "std_out_rank_0" : False/True >> >> or >> >> "std_out_rank" : -1/0/... >> >> Where the latter means that one can define what rank std out should be >> active on, and the former means that if True, we only display std out on >> rank 0. >> >> What ya think? >> > > Agree that the present name is not great. > But no other suggestions? Johan > Garth > > >> Johan >> > >
_______________________________________________ fenics mailing list [email protected] http://fenicsproject.org/mailman/listinfo/fenics
