On 10/17/06, Marvin Humphrey <[EMAIL PROTECTED]> wrote: > > On Oct 16, 2006, at 7:16 AM, David Balmain wrote: > > > Yeah, it is in test/test_helper.c. > > helper.c was the culprit, all right... > > >> I can set up a cron to do nightly smokes. > > > I'll probably take a while to get around to it. > > Weirdo. > > :D > > I'd LUV to have regular smoke tests done for me on systems I don't > have access to! The big one for me is Windows. Fortunately, there's > a bunch of people on PerlMonks who'll run tests for me on their > Windows boxes when I ask.
You're right. I'm a fool to pass up such an offer so lightly. I guess I just really want a Mac user within the Ferret community to take ownership of this. > I'll probably whip up a Perl script that smokes Ferret. If I don't > generalize it (assume availability of svn, etc), that's cake -- 50 > lines, including the email message. The only reason I didn't > volunteer at first is that I figured you could write one in Ruby and > then you might get some other smokers besides me. You're right. I'll do this. > > Anyway, don't spend too much time on this. > > I didn't. But it wasn't hard to find something which made the > failing tests go away. Patch below. > > The patch might not be 100% optimal -- I didn't bother looking at how > POSH implements those functions. I'll leave that to you. Funnily enough the patch reduces the operation to a no-op. I guess I don't need to worry about endianess here since floats have the same endianess as integers. I should have thought about that a little more and I could have saved you the trouble of having to look at it. :P > Meanwhile, I'll go implement the same functionality for Charmonizer. > Funny how I've been working on this very issue! Great. I'm going to swap out POSH for charminizer in Ferret ASAP. Thanks again Marvin. I'll check smoke_test.rb into the base directory of the Ferret repo when I'm done. Cheers, Dave > > I think it is better > > for both of us if you concentrate on Lucy. I've seen a lot of action > > recently on the commits list. :D > > Yeah, it's nice when a concept works out and stuff just flows... :) > > Marvin Humphrey > Rectangular Research > http://www.rectangular.com/ > > Index: c/src/helper.c > =================================================================== > --- c/src/helper.c (revision 653) > +++ c/src/helper.c (working copy) > @@ -14,13 +14,21 @@ > { > union { f_i32 i; float f; } tmp; > tmp.f = f; > +#ifdef POSH_LITTLE_ENDIAN > return POSH_LittleU32(tmp.i); > +#else > + return POSH_BigU32(tmp.i); > +#endif > } > float int2float(f_i32 i32) > { > union { f_i32 i; float f; } tmp; > +#ifdef POSH_LITTLE_ENDIAN > tmp.i = POSH_LittleU32(i32); > +#else > + tmp.i = POSH_BigU32(i32); > +#endif > return tmp.f; > } > > _______________________________________________ > Ferret-talk mailing list > [email protected] > http://rubyforge.org/mailman/listinfo/ferret-talk > _______________________________________________ Ferret-talk mailing list [email protected] http://rubyforge.org/mailman/listinfo/ferret-talk
