ffmpeg | branch: master | Ganesh Ajjanagadde <gajjanaga...@gmail.com> | Wed Jan 6 20:57:47 2016 -0800| [7ab37cae34b3845de7b689d167661bb4a5c2ab5b] | committer: Ganesh Ajjanagadde
ffmpeg: check fclose return values In the spirit of commit a956840cbc. Simple method to reproduce: pass -vstats_file /dev/full to ffmpeg. All raw fclose usages in ffmpeg.c taken care of here. Reviewed-by: Michael Niedermayer <mich...@niedermayer.cc> Signed-off-by: Ganesh Ajjanagadde <gajjanaga...@gmail.com> > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=7ab37cae34b3845de7b689d167661bb4a5c2ab5b --- ffmpeg.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/ffmpeg.c b/ffmpeg.c index 659bd7f..86a0960 100644 --- a/ffmpeg.c +++ b/ffmpeg.c @@ -554,8 +554,12 @@ static void ffmpeg_cleanup(int ret) av_freep(&input_streams[i]); } - if (vstats_file) - fclose(vstats_file); + if (vstats_file) { + if (fclose(vstats_file)) + av_log(NULL, AV_LOG_ERROR, + "Error closing vstats file, loss of information possible: %s\n", + av_err2str(AVERROR(errno))); + } av_freep(&vstats_filename); av_freep(&input_streams); @@ -4200,7 +4204,10 @@ static int transcode(void) ost = output_streams[i]; if (ost) { if (ost->logfile) { - fclose(ost->logfile); + if (fclose(ost->logfile)) + av_log(NULL, AV_LOG_ERROR, + "Error closing logfile, loss of information possible: %s\n", + av_err2str(AVERROR(errno))); ost->logfile = NULL; } av_freep(&ost->forced_kf_pts); _______________________________________________ ffmpeg-cvslog mailing list ffmpeg-cvslog@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-cvslog