This is an automated email from the git hooks/post-receive script.

Git pushed a commit to branch master
in repository ffmpeg.

The following commit(s) were added to refs/heads/master by this push:
     new 3b19a61837 avcodec/vorbisdec: validate windowtype and transformtype
3b19a61837 is described below

commit 3b19a618370488de4ff72657cec4157a3f9fe4a4
Author:     Hassan Hany <[email protected]>
AuthorDate: Thu Jan 22 15:31:41 2026 +0200
Commit:     michaelni <[email protected]>
CommitDate: Thu Apr 16 10:24:41 2026 +0000

    avcodec/vorbisdec: validate windowtype and transformtype
---
 libavcodec/vorbisdec.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/libavcodec/vorbisdec.c b/libavcodec/vorbisdec.c
index aff95f44a9..ba99c01307 100644
--- a/libavcodec/vorbisdec.c
+++ b/libavcodec/vorbisdec.c
@@ -908,8 +908,13 @@ static int vorbis_parse_setup_hdr_modes(vorbis_context *vc)
         vorbis_mode *mode_setup = &vc->modes[i];
 
         mode_setup->blockflag     = get_bits1(gb);
-        mode_setup->windowtype    = get_bits(gb, 16); //FIXME check
-        mode_setup->transformtype = get_bits(gb, 16); //FIXME check
+        mode_setup->windowtype    = get_bits(gb, 16);
+        mode_setup->transformtype = get_bits(gb, 16);
+        if (mode_setup->transformtype != 0 || mode_setup->windowtype != 0) {
+            av_log(vc->avctx, AV_LOG_WARNING,
+                   "Invalid mode: windowtype %u, transformtype %u (both must 
be 0)\n",
+                    mode_setup->windowtype, mode_setup->transformtype);
+        }
         GET_VALIDATED_INDEX(mode_setup->mapping, 8, vc->mapping_count);
 
         ff_dlog(NULL, " %u mode: blockflag %d, windowtype %d, transformtype 
%d, mapping %d\n",

_______________________________________________
ffmpeg-cvslog mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to