This is an automated email from the git hooks/post-receive script.

Git pushed a commit to branch master
in repository ffmpeg.

commit e3c8e7fbbf998559738c9df84fdba6cff894862e
Author:     Ruk Doe <[email protected]>
AuthorDate: Sat Oct 10 12:04:27 2026 +0900
Commit:     michaelni <[email protected]>
CommitDate: Fri Nov 6 04:39:07 2026 +0000

    avcodec/libaribcaption: free the render result after converting it
    
    aribcc_renderer_render() fills ctx->render_result with images that are
    owned by the caller and must be released with
    aribcc_render_result_cleanup(). The bitmap path did this only for the
    "unchanged", "no image" and unknown-status returns. After converting the
    images into AVSubtitleRects, and on the error path, the result was left
    allocated, and the next call overwrote it without freeing it. Every
    rendered caption therefore leaked its bitmaps.
    
    The images are not used after conversion, so release them before
    returning from both paths.
    
    Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
    Claude-Session: https://claude.ai/code/session_01DdDiDRusmi6eD7qSrKBjHb
    Reported-by: Forgejo_Fairy
    Reference: #24067
---
 libavcodec/libaribcaption.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libavcodec/libaribcaption.c b/libavcodec/libaribcaption.c
index 340e8866f8..03deca7a8b 100644
--- a/libavcodec/libaribcaption.c
+++ b/libavcodec/libaribcaption.c
@@ -493,6 +493,7 @@ static int 
aribcaption_trans_bitmap_subtitle(ARIBCaptionContext *ctx)
             av_log(ctx, AV_LOG_WARNING, "CLUT overflow (%d).\n", 
ctx->clut_overflow);
     }
     sub->num_rects = rect_idx;
+    aribcc_render_result_cleanup(&ctx->render_result);
 
     return rect_idx;
 
@@ -508,6 +509,7 @@ fail:
         av_freep(&sub->rects);
     }
     sub->num_rects = 0;
+    aribcc_render_result_cleanup(&ctx->render_result);
 
     return ret;
 }

-- 
To stop receiving notification emails like this one, please contact
[email protected].
_______________________________________________
ffmpeg-cvslog mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to