PR #24373 opened by add-uos-ffmpeg
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/24373
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/24373.patch

window_upper_left_corner_x/_y were printed twice within the geometry
loop of print_dynamic_hdr10_plus(). Remove the redundant pair;
duplicates silently overwrite each other in JSON/flat output.

Signed-off-by: zhanghongyuan <[email protected]>

# Summary of changes

drop duplicate HDR10+ window corner fields


- fix before:

    $ ffprobe -show_packets -select_streams v  -show_entries 
packet=side_data_list -of flat hdr10p_2win.mkv | grep window
    packets.packet.0.side_data_list.side_data.0.num_windows=2
    
packets.packet.0.side_data_list.side_data.0.window_upper_left_corner_x="100/1"
    
packets.packet.0.side_data_list.side_data.0.window_upper_left_corner_y="120/1"
    
packets.packet.0.side_data_list.side_data.0.window_lower_right_corner_x="500/1"
    
packets.packet.0.side_data_list.side_data.0.window_lower_right_corner_y="520/1"
    
packets.packet.0.side_data_list.side_data.0.window_upper_left_corner_x="100/1"
    
packets.packet.0.side_data_list.side_data.0.window_upper_left_corner_y="120/1"

- fix after:

    $ ffprobe -show_packets -select_streams v  -show_entries 
packet=side_data_list -of flat hdr10p_2win.mkv | grep window
    packets.packet.0.side_data_list.side_data.0.num_windows=2
    
packets.packet.0.side_data_list.side_data.0.window_upper_left_corner_x="100/1"
    
packets.packet.0.side_data_list.side_data.0.window_upper_left_corner_y="120/1"
    
packets.packet.0.side_data_list.side_data.0.window_lower_right_corner_x="500/1"
    
packets.packet.0.side_data_list.side_data.0.window_lower_right_corner_y="520/1"



>From 63e3c3ef7f37661223c1eb2564ed752b55ff7a7d Mon Sep 17 00:00:00 2001
From: zhanghongyuan <[email protected]>
Date: Sat, 5 Sep 2026 09:07:33 +0800
Subject: [PATCH] fftools/ffprobe: drop duplicate HDR10+ window corner fields

window_upper_left_corner_x/_y were printed twice within the geometry
loop of print_dynamic_hdr10_plus() (copy-paste leftover). Remove the
redundant pair, which emits duplicate lines in flat output and
duplicate keys in JSON.

Signed-off-by: zhanghongyuan <[email protected]>
---
 fftools/ffprobe.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c
index 31f74106f9..cc622cfdc3 100644
--- a/fftools/ffprobe.c
+++ b/fftools/ffprobe.c
@@ -748,10 +748,6 @@ static void print_dynamic_hdr10_plus(AVTextFormatContext 
*tfc, const AVDynamicHD
                 params->window_lower_right_corner_x,'/');
         print_q("window_lower_right_corner_y",
                 params->window_lower_right_corner_y,'/');
-        print_q("window_upper_left_corner_x",
-                params->window_upper_left_corner_x,'/');
-        print_q("window_upper_left_corner_y",
-                params->window_upper_left_corner_y,'/');
         print_int("center_of_ellipse_x",
                   params->center_of_ellipse_x ) ;
         print_int("center_of_ellipse_y",
-- 
2.52.0

_______________________________________________
ffmpeg-devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to