Hi, 2014-08-02 14:48 GMT+02:00 Michael Niedermayer <michae...@gmx.at>: > is this for apply/push or just RFC/WIP ?
in-between. I had expected Mickael Raulet to comment if he was seeing something not compatible with this. I think the bipred code is a bit more mature since Ronald comments (iirc), so premature optimization is probably a bit strong. Once Mickael is OK, then I'd agree with you about applying it. > you say "Premature optimization and overall not that useful." > i would tend to suggest to apply it as it improves speed ... I was saying this mostly because it doesn't really register overall: MC is around 20% in ffhevc for starters. > seems to fail with > libavcodec/x86/hevc_mc.asm:1258: error: (add:2) cannot reference symbol > `MAX_PB_SIZE' in preprocessor That's actually the biggest beef I have with this patchset: MAX_PB_SIZE is a C and asm define, and the 2 need to be synchronized manually. I don't see how it could go beyond 64 (max block size in hevc), so the issue is rhetorical. I'm busy atm so I don't expect a new patchset soon. Best regards, -- Christophe _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
