On 22.08.2014, at 22:31, Deb Mukherjee <debar...@google.com> wrote:
> +// returns 0 on success, 1 on unsupported

Please choose one of the standard ways, either 1 for success and 0 failure, or 
negative failure, 0 or positive success. This variant, at least in the context 
of FFmpeg, is just confusing/misleading
Though potentially just returning the pixfmt and using an invalid value on 
error might work out even better, but not sure and I don't have a strong 
opinion on that.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Reply via email to