On Tue, Sep 02, 2014 at 07:41:40PM +0200, Reimar Döffinger wrote: > On Tue, Sep 02, 2014 at 05:03:56PM +0200, Michael Niedermayer wrote: > > On Tue, Sep 02, 2014 at 01:52:24PM +0200, Jörg Krause wrote: > > > > > > > > > Am 02.09.2014 12:40 schrieb Michael Niedermayer: > > > >On Tue, Sep 02, 2014 at 12:33:26PM +0200, Jörg Krause wrote: > > > >>Add the feature test macro which is required for building with the > > > >>musl toolchain. > > > >> > > > >>The feature test macro _XOPEN_SOURCE = 600 provides the XSI-compliant > > > >>version of strerror_r(). > > > > > > > >is there a reason why you dont set it from configure ? > > > >similar to the existing "-D_XOPEN_SOURCE=600" code in configure ? > > > > > > > >[...] > > > > > > I followed the recommendation from the GNU C Library Reference > > > Manual, ch. 1.3.4 Feature Test Macro: > > > > > > You should define these macros by using ‘#define’ preprocessor > > > directives at the top of your source code files. These directives > > > must come before any #include of a system header file. It is best to > > > make them the very first thing in the file, preceded only by > > > comments. You could also use the ‘-D’ option to GCC, but it's better > > > if you make the source files indicate their own meaning in a > > > self-contained way. > > > > > > Do you prefer to define the macro in configure? > > > > i prefer that all libcs are handled the same way > > And to be honest the configure check seems backwards to me, why isn't > -D_XOPEN_SOURCE=600 used by default?
no idea > Do all of klibc, bionic, mingw32, mingw64, cygwin/newlib, msvcrt break > if you add it? [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Awnsering whenever a program halts or runs forever is On a turing machine, in general impossible (turings halting problem). On any real computer, always possible as a real computer has a finite number of states N, and will either halt in less than N cycles or never halt.
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
