On 03.09.2014, at 22:09, Michael Niedermayer <michae...@gmx.at> wrote: > On Wed, Sep 03, 2014 at 08:46:04PM +0200, Reimar Döffinger wrote: >> On 03.09.2014, at 18:49, Michael Niedermayer <michae...@gmx.at> wrote: >>> This allows using fs/<random_fate_sample> from the directory where ffmpeg >>> was build >>> for example in bug reports. >>> >>> Alternatively this could be created from the Makefile >>> >>> This of course works only on OS and file-systems which support links >> >> Not sure what ln_s is or does, but there are cases where ln -s will have a >> dummy implementation that does cp instead. >> Especially for this reason I rather don't like having this as something that >> is enabled by default. > > the code checks if theres real link support before linking the > fate samples > if its not supported nothing is created
Ah, so that's what all that code is there for :) Then I change my comment to request that you added a comment saying it checks for working ln. I'd also suggest that one of the clean make targets should remove the link. And maybe we should remove it in configure as well before (re-)creating or does it already handle that, too, and I missed it? _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
