On Thu, Oct 30, 2014 at 09:26:17PM +0100, Horváth Balázs wrote: > This is my attempt at fixing the broken build because xcbgrab > uses xcb_shape_rectangles, but doesn't link xcb-shape. > > Signed-off-by: Horváth Balázs <q...@qroa.ch> > --- > configure | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/configure b/configure > index e6e3de3..49feee3 100755 > --- a/configure > +++ b/configure > @@ -254,6 +254,7 @@ External library support: > --enable-libxcb enable X11 grabbing using XCB [auto] > --enable-libxcb-shm enable X11 grabbing shm communication [auto] > --enable-libxcb-xfixes enable X11 grabbing mouse rendering [auto] > + --enable-libxcb-xshape enable X11 grabbing shape rendering [auto] > --enable-libxvid enable Xvid encoding via xvidcore, > native MPEG-4/Xvid encoder exists [no] > --enable-libzmq enable message passing via libzmq [no] > @@ -1387,6 +1388,7 @@ EXTERNAL_LIBRARY_LIST=" > libxcb > libxcb_shm > libxcb_xfixes > + libxcb_shape > libxvid > libzmq > libzvbi > @@ -5040,8 +5042,13 @@ if enabled libxcb; then > enabled libxcb_xfixes && die "ERROR: libxcb_xfixes not found"; > } && enable libxcb_xfixes; } > > - add_cflags "$xcb_event_cflags $xcb_shm_cflags $xcb_xfixes_cflags" > - add_extralibs "$xcb_event_libs $xcb_shm_libs $xcb_xfixes_libs" > + disabled libxcb_shape || { > + check_pkg_config xcb-shape xcb/shape.h xcb_shape_rectangles || { > + enabled libxcb_shape && die "ERROR: libxcb_shape not found"; > + } && enable libxcb_shape; } > + > + add_cflags "$xcb_event_cflags $xcb_shm_cflags $xcb_xfixes_cflags > $xcb_shape_cflags" > + add_extralibs "$xcb_event_libs $xcb_shm_libs $xcb_xfixes_libs > $xcb_shape_cflags"
doesnt this still break build if someone uses --disable-libxcb-xshape ? [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Frequently ignored answer#1 FFmpeg bugs should be sent to our bugtracker. User questions about the command line tools should be sent to the ffmpeg-user ML. And questions about how to use libav* should be sent to the libav-user ML.
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel