On 5 November 2014 12:25, Stefano Sabatini <stefa...@gmail.com> wrote:
> On date Monday 2014-11-03 00:54:01 +0100, Lukasz Marek encoded: > > On 03.11.2014 00:40, Stefano Sabatini wrote: > > >On date Sunday 2014-11-02 19:19:14 +0100, Lukasz Marek encoded: > > >>TODO: bump micro > > >> > > >>Many common codec options are not via ffm protocol. > > >>This commit adds common A/V encoding options to protocol. > > >> > > >>Signed-off-by: Lukasz Marek <lukasz.m.lu...@gmail.com> > > >>--- > > >> libavformat/ffmdec.c | 78 > ++++++++++++++++++++++++++++++++++++++++++++++++++++ > > >> libavformat/ffmenc.c | 60 ++++++++++++++++++++++++++++++++++++++++ > > >> 2 files changed, 138 insertions(+) > > > > > >My idea was to let the protocol specify the option using the AVOption > > >interface. This way you don't have to update the protocol every time a > > >new option is added to libavcodec, *AND* you can support private codec > > >options. > > > > >> (in near future I will add posibility to set them) > > > > > > I'm curious about that, since that was in my (much neglected) todo > > > list. How do you plan to do that? The only way I see is to fiddle with > > > FFM. > > > > > > > To not spam other thread with offtopic I moved your question here. > > > > I'm not sure yet. In config I wanted to something like that: > > > > VideoCodec libx264 > > #common options: > > AVOptionVideo flags +global_header > > #private option > > > AVOptionVideo libx264:crf 23 > > Why do you think the prefix with the name of the codec is needed? > > > In ffm my first idea was to serialize it as strings in separate section. > > I haven't really thought about it yet. Maybe serializing common > > options would be also good idea. And send only set values. > > My idea was to generalize the format and serialize the option > key/values. We have the same or similar idea. I am about half way to implement that for private options. I just dont know if send values as strings or in binary form where possible. I think sending both key and val as string is to most generic so probably will do it this way first. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
