Re: [FFmpeg-devel] [PATCH 07/11] lavu/dict: add av_dict_serialize

[Lukasz Marek]

On 20.11.2014 02:17, Michael Niedermayer wrote:
[...]
+{
+    AVDictionary *dict = NULL;
+    char *buffer = NULL;
+
+    printf("Testing av_dict_get_string() and
av_dict_parse_string()");
+    av_dict_get_string(dict, &buffer, '=', ',');
+    printf("%s\n", buffer);
+    av_freep(&buffer);
+    av_dict_set(&dict, "aaa", "aaa", 0);
+    av_dict_set(&dict, "b,b", "bbb", 0);
+    av_dict_set(&dict, "c=c", "ccc", 0);
+    av_dict_set(&dict, "ddd", "d,d", 0);
+    av_dict_set(&dict, "eee", "e=e", 0);
+    av_dict_set(&dict, "f,f", "f=f", 0);
+    av_dict_set(&dict, "g=g", "g,g", 0);
+    test_separators(dict, ',', '=');
+    av_dict_free(&dict);
+    av_dict_set(&dict, "aaa", "aaa", 0);

i tried this instead
av_dict_set(&dict, "a\\,=\'\"aa", "a\\,=\'\"aa", 0);

and it doesnt seem to work

obviously av_get_token is broken, i'm not going to fix it soon, so
consider patchset dropped unless no one does or wahtever

i dont think we need \ as a seperator, supporting that case would
only add work
I suggest this:

OK. I will fix it later.

Updated.


  Makefile |    1
  dict.c   |   90 
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
  dict.h   |   18 ++++++++++++
  3 files changed, 109 insertions(+)
5eb2cb6e7f068d0ca4c39f674e8087ba74e2972f  
0001-lavu-dict-add-av_dict_serialize.patch
 From a84dbe1ef00797d79a96664dfd701fd612f027c5 Mon Sep 17 00:00:00 2001
From: Lukasz Marek <lukasz.m.lu...@gmail.com>
Date: Sun, 16 Nov 2014 01:45:07 +0100
Subject: [PATCH] lavu/dict: add av_dict_serialize

TODO: bump minor, update doc/APIchanges

LGTM

pushed this one.

I haven't read comments for other commits deeply, but seems minor so 
probably will resend fixes tomorrow.

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel