Hi,

2014-11-30 17:08 GMT+01:00 Michael Niedermayer <michae...@gmx.at>:
> On Sun, Nov 30, 2014 at 02:45:54PM +0100, Christophe Gisquet wrote:
> its the inverse of the amount, so smaller numbers should result in
> more noise with 1 resulting in the maximum

True, the modulo means the smaller the value, the more frequent it
happens. State isn't updated from that modulo, so indeed I've mistaken
it for a seed.

Hopefully, the attached patch addresses both the need for correct
explanation as well as Lou's comment.

-- 
Christophe
From 7e6cc5a8c82cde93c6138081cee634deca6d8378 Mon Sep 17 00:00:00 2001
From: Christophe Gisquet <christophe.gisq...@gmail.com>
Date: Sun, 30 Nov 2014 11:59:22 +0100
Subject: [PATCH 4/4] noise_bsf: mention the parameter in the docs

This looks more like a seed than an amount, as the variable name
could lead to think.
---
 doc/bitstream_filters.texi | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi
index 8124238..6431ce8 100644
--- a/doc/bitstream_filters.texi
+++ b/doc/bitstream_filters.texi
@@ -21,7 +21,8 @@ name after a '='.
 ffmpeg -i INPUT -c:v copy -bsf:v filter1[=opt1=str1/opt2=str2][,filter2] OUTPUT
 @end example
 
-Below is a description of the currently available bitstream filters.
+Below is a description of the currently available bitstream filters,
+with their parameters, if any.
 
 @section aac_adtstoasc
 
@@ -143,9 +144,16 @@ ffmpeg -i frame_%d.jpg -c:v copy rotated.avi
 Damages the contents of packets without damaging the container. Can be
 used for fuzzing or testing error resilience/concealment.
 
+Parameters:
+A numeral string, whose value is related to how often output bytes will
+be modified. Therefore, values below or equal to 0 are forbidden, and
+the lower the more frequent bytes will be modified, with 1 meaning
+every byte is modified.
+
 @example
-ffmpeg -i INPUT -c copy -bsf noise output.mkv
+ffmpeg -i INPUT -c copy -bsf noise[=1] output.mkv
 @end example
+applies the modification to every byte.
 
 @section remove_extra
 
-- 
1.9.2.msysgit.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Reply via email to