On Fri, Jan 30, 2015 at 08:55:45AM -0700, Roger Pack wrote: > On 1/30/15, Don Moir <donm...@comcast.net> wrote: > > > > ----- Original Message ----- > > From: "Roger Pack" <rogerdpa...@gmail.com> > > To: "FFmpeg development discussions and patches" <ffmpeg-devel@ffmpeg.org> > > Sent: Friday, January 30, 2015 7:09 AM > > Subject: [FFmpeg-devel] PATCH dshow show devices options > > > > > >> See attached. Hope I didn't get it reversed or something weird. > >> -roger- > >> > > -#define DSHOWDEBUG 0 > > +/* Set to 1 to enable lots of verbose DSHOW debug info the logger */ > > +#define DSHOWDEBUG 1 > > > > Seems to turn on a lot of over head even if not displayed. > > Oops good eye. Thought I had just added the comment but no. > Revision attached. > > If you'd like to review the other recent dshow commits feedback > welcome there also. > Cheers! > -roger-
> dshow.c | 12 +++++++----- > dshow_capture.h | 1 + > 2 files changed, 8 insertions(+), 5 deletions(-) > 8cc6a2d1787151cc1a72be27dd5d5178784eb15a > 0001-dshow-show-incremental-values-allowed.patch > From e8e08ee49c6f80b02334891207d9f0d1b165b4b9 Mon Sep 17 00:00:00 2001 > From: rogerdpack <rogerpack2...@gmail.com> > Date: Fri, 30 Jan 2015 08:53:16 -0700 > Subject: [PATCH] dshow: show incremental values allowed > > Signed-off-by: rogerdpack <rogerpack2...@gmail.com> > --- > libavdevice/dshow.c | 12 +++++++----- > libavdevice/dshow_capture.h | 1 + > 2 files changed, 8 insertions(+), 5 deletions(-) > > diff --git a/libavdevice/dshow.c b/libavdevice/dshow.c > index d03670e..f823793 100644 > --- a/libavdevice/dshow.c > +++ b/libavdevice/dshow.c > @@ -365,18 +365,18 @@ dshow_cycle_formats(AVFormatContext *avctx, enum > dshowDeviceType devtype, > enum AVCodecID codec_id = av_codec_get_id(tags, > bih->biCompression); > AVCodec *codec = avcodec_find_decoder(codec_id); > if (codec_id == AV_CODEC_ID_NONE || !codec) { > - av_log(avctx, AV_LOG_INFO, " unknown compression > type 0x%X", (int) bih->biCompression); > + av_log(avctx, AV_LOG_INFO, " unknown compression > type [please report] 0x%X", (int) bih->biCompression); this maybe should say where to report to like email address or url of ffmpeg-devel the other changes look fine though if one wanted to nitpick could be in seperate patches [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No human being will ever know the Truth, for even if they happen to say it by chance, they would not even known they had done so. -- Xenophanes
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel