Quoting James Almer (2020-04-20 15:39:19) > On 4/20/2020 10:30 AM, Anton Khirnov wrote: > > Quoting James Almer (2020-04-17 05:10:08) > >> Signed-off-by: James Almer <jamr...@gmail.com> > >> --- > >> libavcodec/qpeg.c | 1 + > >> 1 file changed, 1 insertion(+) > > > > Looks good. > > Could have INIT_CLEANUP too, it seems. > > No, since the only way for init() to fail now is if allocating a->ref > fails, and if that happens then there's nothing to free.
Which means it's trivially INIT_CLEANUP. I believe the intent was to gradually mark all the codecs as INIT_CLEANUP and then drop the flag so they all behave the same. Anyway, that's just a nit, feel free to ignore. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
