Limin Wang (12020-04-21): > OK, below is the commit log, please help to review whether it's your expected > log: > > NOTE about the testing effect: > subtitle packet will be marked as keyframe, it'll change below testing > reference > files: > tests/ref/fate/binsub-movtextenc and tests/ref/fate/sub2video > > audio packet will be marked as keyframe, it'll change below testing reference > file > tests/ref/fate/movenc
You are writing in the future tense, meaning you are making a prediction. You need to explain what you did, and the results. For example, did you re-run the tests with -w, as suggested in https://ffmpeg.org/pipermail/ffmpeg-devel/2020-April/260837.html to examine the files before and after the change? Regards, -- Nicolas George
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
