> From: Martin Storsjö <mar...@martin.st> > Sent: Tuesday, April 28, 2020 18:28 > To: FFmpeg development discussions and patches <ffmpeg- > de...@ffmpeg.org> > Cc: Fu, Linjie <linjie...@intel.com> > Subject: Re: [FFmpeg-devel] [PATCH v5 1/5] lavc/libopenh264enc: Add > qmin/qmax support > > On Tue, 28 Apr 2020, Linjie Fu wrote: > > > Clip iMinQp/iMaxQp to (1, 51) if user specified qp range > > explicitly since QP = 0 is not well supported currently > > in libopenh264, otherwise leave iMinQp/iMaxQp untouched > > and use the values initialized in FillDefault(). > > I'd suggest changing the commit message. It's not that "QP = 0 is not well > supported". Setting QP=0 means "use the defaults", and that's an intended > usecase. It's unfortunate that the library logs a warning message in this > case though. > > Can you make a PR to openh264 to change the verbosity level of that > message, from warning to info?
PR filed in: https://github.com/cisco/openh264/pull/3278 - Linjie _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
