Apr 30, 2020, 10:52 by d...@lynne.ee: > Apr 29, 2020, 16:00 by mich...@niedermayer.cc: > >> On Tue, Apr 28, 2020 at 07:22:08PM +0200, Lynne wrote: >> >>> Apr 28, 2020, 16:07 by d...@lynne.ee: >>> >>> > Apr 28, 2020, 15:59 by mattias.wad...@gmail.com: >>> > >>> >> >>> >> >>> > Well, I consider CRC checking a part of correctly parsing ogg, so I think >>> > its best to leave it on >>> > all the time. >>> > >>> >>> Did a new version of the patches. >>> The first two are identical, save for some minor style tweaks. >>> The last one now ensures the max page size, 65k, is available for seeking >>> and speeds up >>> decoding on new/replacement streams since the offset was incorrect. >>> I think its worth it. >>> >>> I'm also close to figuring out how to make chained Opus work, will send a >>> patch once I do. >>> >> >> This patchset seems to detect a crc error in: >> Your patchset is probably correct in this as there are artifacts before, >> just reporting this as i noticed it. >> >> ./ffmpeg -i ~/tickets/2121/vlc-bug.oga c.wav >> >> sample should be here: >> https://trac.ffmpeg.org/raw-attachment/ticket/2121/vlc-bug.oga >> >> thanks >> > > Thanks, checked the sample, it seems corrupt so patch is working as intended. > I plan to push the patchset tonight, unless someone has comments or reviews. >
Pushed. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".