May 1, 2020, 14:16 by mich...@niedermayer.cc: > Fixes: out of array write > Fixes: Regression since f619e1ec66b89215582eff4404b681b760540b4f > > Signed-off-by: Michael Niedermayer <mich...@niedermayer.cc> > --- > libavformat/oggdec.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/libavformat/oggdec.c b/libavformat/oggdec.c > index a9034ea61c..7dd48af66c 100644 > --- a/libavformat/oggdec.c > +++ b/libavformat/oggdec.c > @@ -441,6 +441,12 @@ static int ogg_read_page(AVFormatContext *s, int *sid, > int probing) > > os = ogg->streams + idx; > > + ret = buf_realloc(os, size); > + if (ret < 0) { > + av_free(readout_buf); > + return ret; > + } > + > memcpy(os->buf + os->bufpos, readout_buf, size); > av_free(readout_buf); >
LGTM, though if you choose to allocate 65k at the start this would be unnecessary. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".