On 02/05/2020 15:46, James Almer wrote: >> + if ((avctx->flags & AV_CODEC_FLAG_PASS1 || avctx->flags & >> AV_CODEC_FLAG_PASS2) && !avctx->bit_rate) { > > Maybe avctx->flags & (AV_CODEC_FLAG_PASS1 | AV_CODEC_FLAG_PASS2) instead.
I thought about it, but I think the way I already have it is a little clearer, and so prefer it. >> if (avctx->flags & AV_CODEC_FLAG_PASS2) { >> if (!avctx->stats_in) { >> av_log(avctx, AV_LOG_ERROR, "No stats file provided for second >> pass.\n"); >> > > LGTM either way. Pushed, thanks. - Derek _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".