On Fri, May 29, 2020 at 11:54 PM Michael Niedermayer <mich...@niedermayer.cc> wrote: > > On Fri, May 29, 2020 at 11:23:20PM +0530, Gautam Ramakrishnan wrote: > > On Fri, May 29, 2020 at 5:01 AM Michael Niedermayer > > <mich...@niedermayer.cc> wrote: > > > > > > On Fri, May 29, 2020 at 12:33:01AM +0530, gautamr...@gmail.com wrote: > > > > From: Gautam Ramakrishnan <gautamr...@gmail.com> > > > > > > > > I have attempted to write a JPEG2000 Parser. Have tested > > > > by generating a file containing 14 frames, as mentioned > > > > by Micheal. Have also tried testing with various packet > > > > sizes by setting -frame_size option. Need feedback on the > > > > code and on further testing. > > > > --- > > > > libavcodec/Makefile | 1 + > > > > libavcodec/jpeg2000_parser.c | 190 +++++++++++++++++++++++++++++++++++ > > > > libavcodec/parsers.c | 1 + > > > > 3 files changed, 192 insertions(+) > > > > create mode 100644 libavcodec/jpeg2000_parser.c > > > > > > can you add some test to fate for this ? > > > (doesnt need to be related to the tests you did, but can of course) > > > such a test would also make it easy for others to test the code on > > > less common hardware like big endian ... > > > This can also be very simple test if its not easy > > Small doubt, so the jpeg2000 stream to be parsed goes in the > > test-suite directory and the corresponding framecrc goes into the > > test/ref directory? Is my understanding right? > > ideally the teststream is generated by our muxers / encoders, that way > it doesnt need to be added to the fate suite > and it also teste more code as a side effect I did not understand this clearly. Do you mean the test should take some images already there in the test-suite, create a teststream, and run the test on that teststream? > > thx > > [...] > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > Take away the freedom of one citizen and you will be jailed, take away > the freedom of all citizens and you will be congratulated by your peers > in Parliament. > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
https://trac.ffmpeg.org/wiki/FATE/AddingATest Is this what I should be looking at? -- ------------- Gautam | _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".