On Mon, Jun 08, 2020 at 04:02:22PM +0200, Nicolas George wrote: > lance.lmw...@gmail.com (12020-06-08): > > From: Limin Wang <lance.lmw...@gmail.com> > > > > Signed-off-by: Limin Wang <lance.lmw...@gmail.com> > > --- > > libavfilter/f_metadata.c | 9 ++++++--- > > 1 file changed, 6 insertions(+), 3 deletions(-) > > > > diff --git a/libavfilter/f_metadata.c b/libavfilter/f_metadata.c > > index 598257b15b..808782d31a 100644 > > --- a/libavfilter/f_metadata.c > > +++ b/libavfilter/f_metadata.c > > @@ -31,6 +31,7 @@ > > #include "libavutil/internal.h" > > #include "libavutil/opt.h" > > #include "libavutil/timestamp.h" > > +#include "libavutil/bprint.h" > > #include "libavformat/avio.h" > > #include "avfilter.h" > > #include "audio.h" > > @@ -195,9 +196,11 @@ static void print_file(AVFilterContext *ctx, const > > char *msg, ...) > > > > va_start(argument_list, msg); > > if (msg) { > > - char buf[128]; > > - vsnprintf(buf, sizeof(buf), msg, argument_list); > > - avio_write(s->avio_context, buf, av_strnlen(buf, sizeof(buf))); > > + AVBPrint buf; > > + av_bprint_init(&buf, 0, AV_BPRINT_SIZE_UNLIMITED); > > + av_vbprintf(&buf, msg, argument_list); > > > + avio_write(s->avio_context, buf.str, buf.len); > > Error check missing.
For the print_file is void, so I haven't considered to add error check, can we just print one error message if av_bprint_is_complete checking failed? > > > + av_bprint_finalize(&buf, NULL); > > } > > va_end(argument_list); > > } > > Regards, > > -- > Nicolas George -- Thanks, Limin Wang _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".