James Almer (12020-07-10): > Because my opinion and tastes are not yours. I already said why *i* > consider it ugly. It doesn't need to fit *your* conception of ugliness.
If it is only a matter of taste, then it cannot count as an argument. But tastes are frequently a proxy for minor factors. If you can express the minor factors behind your tastes, they can count as arguments. Which is what I am trying to do about my tastes. One of these minor factors: there is frequently a "int ret" variable and a "return ret" at the end. If the return value conflates size with the error code, ret cannot be used, which means some kind of "if (size < 0) ret = size;" need to happen, but would easily be forgotten, initially or in refactoring. > int av_image_fill_plane_sizes(size_t sizes[4], enum AVPixelFormat > pix_fmt, const ptrdiff_t linesizes[4]); So the question is now: is the total size useful enough to warrant an extra return parameter or not? I have no advice on the question. Regards, -- Nicolas George
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
