On 8/11/20, Nicolas George <geo...@nsup.org> wrote: > Paul B Mahol (12020-08-11): >> ffmpeg | branch: master | Paul B Mahol <one...@gmail.com> | Tue Aug 11 >> 10:55:16 2020 +0200| [4dbb75c437117285cfa195c437a8a1ee898e9293] | >> committer: Paul B Mahol >> >> avfilter/vf_xfade: check that fps between inputs are valid >> >> > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=4dbb75c437117285cfa195c437a8a1ee898e9293 >> --- >> >> libavfilter/vf_xfade.c | 16 ++++++++++++++++ >> 1 file changed, 16 insertions(+) > > This should not have been pushed. If it had been posted for review, I > would have had a chance to explain to you that filters are not supposed > to use information from the frame rate, as it is not negotiated and > supposed to be only indicative. > > Filters that need matching timestamps between frames on separate streams > should use framesync or an equivalent logic.
You clearly do not know anything about xfade filter. Framesync can not be used at all. > > -- > Nicolas George > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
