On Mon, Aug 17, 2020 at 12:12 PM Derek Buitenhuis <
derek.buitenh...@gmail.com> wrote:

> Patch lacks the context for stream_size here - will it always be
> correct? Only asking since the check for the coede below this will
> have changed from avio_size(pb) to stream_size.
>

stream_size == avio_size(pb), just computed once at the top.


> Can mov_read_sidx not return an error?
>

Fixed.


> Needs two more spaces.
>

Done.


> Can be an else statement.
>

Can't be an else statement since the prior clause modifies is_complete.

Thanks!

Attachment: sidx_fix_v1.patch
Description: Binary data

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Reply via email to