On Wed, Mar 18, 2015 at 10:01:36PM +0100, Andreas Cadhalpun wrote:
> On 18.03.2015 16:59, tomas.har...@codemill.se wrote:
> > On 2015-03-17 16:13, Andreas Cadhalpun wrote:
> >> On 17.03.2015 10:17, tomas.har...@codemill.se wrote:
> >>> On 2015-03-14 18:03, Andreas Cadhalpun wrote:
> >>> [PATCH 2/2] mxfenc: don't try to write footer without header:
> >>>
> >>>> + if (!mxf->header_written ||
> >>>> + (s->oformat == &ff_mxf_opatom_muxer &&
> >>>> !mxf->body_partition_offset)) {
> >>>> + err = AVERROR_UNKNOWN;
> >>>> + goto end;
> >>>> + }
> >>>> +
> >>>
> >>> AVERROR_UNKNOWN?
> >>
> >> It's unclear why the header was not written or body_partition_offset
> >> not allocated. It could e.g. be due to invalid options, not supported
> >> codecs, or just out of memory.
> >> Do you think AVERROR(EINVAL) or even just -1 would be better?
> >>
> >> Best regards,
> >> Andreas
> >
> > No preference really. Perhaps a comment though?
>
> OK. New patch with comment attached.
>
> Best regards,
> Andreas
> > mxfenc.c | 7 +++++++ > 1 file changed, 7 insertions(+) > db5cf2fdfe8a815e8785669644690907a9a5a7fe > 0001-mxfenc-don-t-try-to-write-footer-without-header.patch > From 1424c87b9a786555b294fb9daa9fd2a67be9a30d Mon Sep 17 00:00:00 2001 > From: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> > Date: Wed, 18 Mar 2015 21:57:58 +0100 > Subject: [PATCH] mxfenc: don't try to write footer without header > > This fixes a crash, when trying to mux h264 into mxf_opatom. applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No great genius has ever existed without some touch of madness. -- Aristotle
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
