mån 2020-08-31 klockan 20:07 +0100 skrev Harry Mallon: > +static const MXFLocalTagPair mxf_mastering_display_local_tags[] = { > + { 0x8201, > {0x06,0x0e,0x2b,0x34,0x01,0x01,0x01,0x0e,0x04,0x20,0x04,0x01,0x01,0x01,0x00,0x00}}, > /* Mastering Display Primaries */ > + { 0x8202, > {0x06,0x0e,0x2b,0x34,0x01,0x01,0x01,0x0e,0x04,0x20,0x04,0x01,0x01,0x02,0x00,0x00}}, > /* Mastering Display White Point Chromaticity */ > + { 0x8203, > {0x06,0x0e,0x2b,0x34,0x01,0x01,0x01,0x0e,0x04,0x20,0x04,0x01,0x01,0x03,0x00,0x00}}, > /* Mastering Display Maximum Luminance */ > + { 0x8204, > {0x06,0x0e,0x2b,0x34,0x01,0x01,0x01,0x0e,0x04,0x20,0x04,0x01,0x01,0x04,0x00,0x00}}, > /* Mastering Display Minimum Luminance */ > +};
These conflict with existing local tags, as Marton says. It also strikes me that these duplicate the keys already defined in patch 1. Consider having both mxfdec and mxfenc share tables for them. Maybe a better solution would be to have mxfenc automagically come up with local tags for custom ULs, so we avoid these kinds of collisions in the future. /Tomas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".