Quoting Michael Niedermayer (2020-10-03 20:26:20) > On Fri, Oct 02, 2020 at 08:03:25PM +0200, Anton Khirnov wrote: > > Do it only when requested with the AV_CODEC_EXPORT_DATA_VIDEO_ENC_PARAMS > > flag. > > > > Drop previous code using the long-deprecated AV_FRAME_DATA_QP_TABLE* > > API. Temporarily disable fate-filter-pp, fate-filter-pp7, > > fate-filter-spp. They will be reenabled once these filters are converted > > in following commits. > > This patchset updates pp, pp7, spp, fspp, qp, codecview > it seems uspp is missed (as it lacks a fate test i guess)
No, I skipped uspp because it uses more deprecated APIs than just the QP table one. Specifically, the old encoding API and AVCodecContext.coded_frame. Given that: - coded_frame is dropped without replacement - uspp is EXTREMELY slow - we have several other very similar filters I have to wonder whether continued maintenance of uspp makes sense. So I suggest that either - someone cares enough about this filter to maintain it (i.e. convert it to non-deprecated APIs) - we drop it -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
