On Mon, Oct 05, 2020 at 10:18:32AM +0200, Tomas Härdin wrote:
> tor 2020-10-01 klockan 22:13 +0200 skrev Michael Niedermayer:
> > On Thu, Oct 01, 2020 at 03:29:19PM +0100, Harry Mallon wrote:
> > > > On 30 Sep 2020, at 08:32, Michael Niedermayer <mich...@niedermayer.cc> 
> > > > wrote:
> > > > 
> > > > fails on big endian
> > > > 
> > > > --- src/tests/ref/fate/mxf-probe-applehdr10     2020-09-28 
> > > > 23:21:12.291897976 +0200
> > > > +++ tests/data/fate/mxf-probe-applehdr10        2020-09-30 
> > > > 09:31:38.614653806 +0200
> > > > @@ -14,7 +14,7 @@
> > > > has_b_frames=0
> > > > sample_aspect_ratio=1:1
> > > > display_aspect_ratio=16:9
> > > > -pix_fmt=yuv422p10le
> > > > +pix_fmt=yuv422p10be
> > > > level=-99
> > > > color_range=tv
> > > > color_space=bt2020nc
> > > > Test mxf-probe-applehdr10 failed. Look at 
> > > > tests/data/fate/mxf-probe-applehdr10.err for details.
> > > > src/tests/Makefile:255: recipe for target 'fate-mxf-probe-applehdr10' 
> > > > failed
> > > > make: *** [fate-mxf-probe-applehdr10] Error 1
> > > 
> > > It seems fair that the pixel type is in native endian.
> > 
> > maybe but the endianness of the decoder output doesnt belong in the
> > comparission
> > 
> > 
> > > I'm not really familiar enough with FATE to provide a patch to fix this 
> > > though. Do any other FATE tests have wildcards or two versions for big 
> > > and little endian?
> > 
> > i dont see another probe reference file that contains a le/be format
> > 
> > we had le/be issues in other places though where they where fixed by forcing
> > a format with specific endianness in the test IIRC
> 
> How about something like this?

it solves the problem here.
so LGTM

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are too smart to engage in politics are punished by being
governed by those who are dumber. -- Plato 

Attachment: signature.asc
Description: PGP signature

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Reply via email to