mån 2021-01-04 klockan 01:28 +0100 skrev Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt <andreas.rheinha...@gmail.com> > --- > There is also another key that is duplicated: header_open_partition_key > and mxf_jp2k_rsiz. But they seem to mean something different which makes > me wonder if one of these keys is incorrect; I have therefore refrained > from deduplicating them.
Looks like I didn't notice this when I reviewed the patch. This indicates that the MXF muxer that wrote the file that 2af260e3 adds support for is broken. S422m-2006 says that the UL designator for Rsiz should be 04.01.06.03.01.00.00.00. S400m-2004 defines the prefix to this designator, which is the usual 06.0E.2B.34.04.01.01.VV where VV is the registry version. Did we have a sample for this? If you decide to deduplicate rsiz then you should have kind of comment to this effect, and/or a link to this thread and http://ffmpeg.org/pipermail/ffmpeg-devel/2015-March/169591.html The patch itself looks fine. Might as well deduplicate all keys. There's little sense in having separate sets of keys defined for the muxer and demuxer. /Tomas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
