On Wed, 24 Feb 2021 at 17:50, Soft Works <softwo...@hotmail.com> wrote:
> > > > -----Original Message----- > > From: ffmpeg-devel <ffmpeg-devel-boun...@ffmpeg.org> On Behalf Of > > Artem Galin > > Sent: Tuesday, November 3, 2020 7:46 PM > > To: ffmpeg-devel@ffmpeg.org > > Cc: Artem Galin <artem.ga...@intel.com> > > Subject: [FFmpeg-devel] [PATCH v7 8/8] libavfilter/vf_deinterlace_qsv: > > enabling d3d11va support, added mfxhdlpair > > > > Adding DX11 relevant device type checks and adjusting callback with > proper > > MediaSDK pair type support. > > > > Hi Artem, > > I have a few more notes regarding the patch: > > The switch to using mfxhdlpair will cause a regression in case of > VAAPI/OpenCL > Interop. In hwcontext_opencl.cs, function opencl_map_from_qsv, you need to > cast the MemId to mfxHDLPair for getting the surface id. > > OpenCL interop on Windows is a whole different story, but it's not a small > thing > like the above, so you better handle that at a later time. It's not a > regression > anyway because this functionality doesn't exist yet (for D3D11). > > At the same time, that's another reason for NOT changing the default to > D3D11 > because somebody using QSV<=>OpenCL interop would see his commands > failing when you change the default to D3D11. > > I don't know what others here are thinking (because nobody says anything), > but IMO, a patch that doesn't switch the default impl would have less > impact and probably better chances to get merged. > > Kind regards, > softworkz > > Hi Softworkz, D3D11VA works with more variety of HW configurations and there is no DX9 drop in the patch. Feel free to send your version of the patch with interop fix. Thanks, Artem. > > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
