Anton Khirnov (12021-08-09):
> + heatmap_file = av_fopen_utf8(s->heatmap_path, "r");
> + if (!heatmap_file) {
> + av_log(ctx, AV_LOG_ERROR, "cannot open heatmap file %s\n",
> s->heatmap_path);
> + return AVERROR(EINVAL);
> + }
> + ret = load_heatmaps(&s->heatmaps, heatmap_file,
> + s->default_heatmap_w, s->default_heatmap_h);
> + if (ret < 0)
> + return ret;I cannot comment much, but I notice you might be leaking heatmap_file. Why do you do this with a test in each activate() rather than in init() or one of the config_props()? Regards, -- Nicolas George
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
