On Sat, Oct 16, 2021 at 10:06:35AM -0300, James Almer wrote: > On 10/14/2021 10:08 AM, lance.lmw...@gmail.com wrote: > > From: Limin Wang <lance.lmw...@gmail.com> > > > > Signed-off-by: Limin Wang <lance.lmw...@gmail.com> > > --- > > libavfilter/af_replaygain.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/libavfilter/af_replaygain.c b/libavfilter/af_replaygain.c > > index 4bf2763..da5c196 100644 > > --- a/libavfilter/af_replaygain.c > > +++ b/libavfilter/af_replaygain.c > > @@ -428,7 +428,7 @@ static void > > butter_filter_stereo_samples(ReplayGainContext *s, > > // (slowing us down). > > for (j = -4; j < 0; ++j) > > - if (fabs(hist_a[i + j]) > 1e-10 || fabs(hist_b[i + j]) > 1e-10) > > + if (fabsf(hist_a[i + j]) > 1e-10 || fabsf(hist_b[i + j]) > 1e-10) > > Shouldn't the constants also be made into floats? Otherwise the compiler > will probably do a conversion to double.
Yes, will change the 1e-10 to 1e-10f also. > > > break; > > if (!j) { > > @@ -477,7 +477,7 @@ static void > > yule_filter_stereo_samples(ReplayGainContext *s, const float *src, > > // (slowing us down). > > for (j = -20; j < 0; ++j) > > - if (fabs(hist_a[i + j]) > 1e-10 || fabs(hist_b[i + j]) > 1e-10) > > + if (fabsf(hist_a[i + j]) > 1e-10 || fabsf(hist_b[i + j]) > 1e-10) > > break; > > if (!j) { > > > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". -- Thanks, Limin Wang _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".