On 19 Oct 2021, at 10:40, Martin Storsjö wrote:
> On Thu, 7 Oct 2021, J. Dekker wrote: > >> Signed-off-by: J. Dekker <j...@itanimul.li> >> --- >> libavcodec/aarch64/hevcdsp_sao_neon.S | 103 +++++++++++--------------- >> 1 file changed, 44 insertions(+), 59 deletions(-) >> >> diff --git a/libavcodec/aarch64/hevcdsp_sao_neon.S >> b/libavcodec/aarch64/hevcdsp_sao_neon.S >> index 263747149f..c2519da7f5 100644 >> --- a/libavcodec/aarch64/hevcdsp_sao_neon.S >> +++ b/libavcodec/aarch64/hevcdsp_sao_neon.S >> @@ -3,7 +3,7 @@ >> * >> * AArch64 NEON optimised SAO functions for HEVC decoding >> * >> - * Copyright (c) 2020 Josh Dekker <j...@itanimul.li> >> + * Copyright (c) 2020-2021 J. Dekker <j...@itanimul.li> >> * >> * This file is part of FFmpeg. >> * >> @@ -29,64 +29,49 @@ >> // int16_t *sao_offset_val, int sao_left_class, >> // int width, int height) >> function ff_hevc_sao_band_filter_8x8_8_neon, export=1 >> - sub sp, sp, #64 >> - stp xzr, xzr, [sp] > > This one had the right indentation to start with, don't reindent it according > to the new incorrectly indented code you're adding. Yep. This was a mistake, some of (my) previously pushed code is actually incorrect here as well. Instructions should be indented to 9 Columns with the first argument being at 25 Columns. You mentioned in the past about shifting the first argument left by 1 character when it began with a curly brace but I don't see this used in any other files (except the one added by me). Should this still be done? Also do you want a patch to reformat previous code to fit this 9,25 cols alignment? > Also if you're going to reformat this, could you align the left edge of the > operand columns instead of aligning the commas, i.e. making it match the rest > of the asm we have? I.e. like this: > > sp, sp, #64 > xzr, xzr, [sp] Sure, I thought comma aligning here was strange. -- J. Dekker _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
