> On Jan 15, 2022, at 1:40 AM, Thilo Borgmann <thilo.borgm...@mail.de> wrote:
>>
>>> + if (tag == 'M' || tag == 'm') {
>>> + char *seconds = av_stristr(fmt, "%S");
>>> + if (seconds) {
>>> + seconds += 2;
>>> + int len = seconds - fmt + 1;
>>> + char *tmp = av_malloc(len);
>>> + av_strlcpy(tmp, fmt, len);
>>
>> Firstly, mixed variable declaration and statements.
>>
>> Secondly, I think you don’t need ’tmp’, something like
>>
>> av_asprintf(“%.*s.%03d%s", len, fmt, (int)(unow % 1000000) / 1000, seconds);
>
> You know your printf format-string :)
>
> Thanks, v6 attached.
LGTM now. Looking forward to use it for end-to-end latency test.
> -Thilo
>
>
> <v6-0001-lavfi-drawtext-Add-localtime_ms-for-millisecond-p.patch>_______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org <mailto:ffmpeg-devel@ffmpeg.org>
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org <mailto:ffmpeg-devel-requ...@ffmpeg.org> with
> subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
