Am 14.01.22 um 18:57 schrieb Romain Beauxis: > Le ven. 14 janv. 2022 à 11:47, Thilo Borgmann <thilo.borgm...@mail.de> a > écrit : >> >> Am 14.01.22 um 13:57 schrieb Marvin Scholz: >>> >>> >>> On 6 Jan 2022, at 15:24, Romain Beauxis wrote: >>> >>>> * Implement support for AudioConverter >>>> * Switch to AudioConverter's API to convert unsupported PCM >>>> formats (non-interleaved, non-packed) to supported formats >>>> * Minimize data copy. >>>> >>>> This fixes: https://trac.ffmpeg.org/ticket/9502 >>>> >>>> API ref: >>>> https://developer.apple.com/documentation/audiotoolbox/audio_converter_services >>>> >>>> Signed-off-by: Romain Beauxis <to...@rastageeks.org> >>>> --- >>>> This is the first patch of a series of 3 that fix, cleanup and enhance the >>>> avfoundation implementation for libavdevice. >>>> >>>> These patches come from an actual user-facing application relying on >>>> libavdevice’s implementation of avfoundation audio input. Without them, >>>> Avfoundation is practically unusable as it will: >>>> * Refuse to process certain specific audio input format that are actually >>>> returned by the OS for some users (packed PCM audio) >>>> * Drop audio frames, resulting in corrupted audio input. This might have >>>> been >>>> unnoticed with video frames but this makes avfoundation essentially >>>> unusable >>>> for audio. >>>> >>>> The patches are now being included in our production build so they are >>>> tested >>>> and usable in production. >>>> >>> >>> Hi, >>> >>> the patches are still corrupt and do not apply. >>> As stated earlier, please either use git send-email or attach the patch >>> to the mail instead of putting its contents in it, as apparently Mail.app >>> messes them up. >> >> Still the same for me. Do you use git send-email or git format-patch? > > Thanks for checking on this y'all and sorry about these complications. >
> I used git format-patches. I might try git send-email or the github PR > bridge, that seems like a neat trick. github PR sounds like something you don't want. I use format-patch as well and attach the file (not sending via mail.app though). > > I'm working on a new revision of the patches, I discovered more issues > with audio conversion, possibly linked to bugs with the AudioConverter > API. > > I also discovered an API to do the conversion internally without > having to deal with manually reconverting. Hopefully, this also fixes > the issues we uncovered. > > Will post once we have done more testing. All in all, macos sound APIs > are pretty confusing and buggy around the edges it seems. Cool. -Thilo _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".