On 19 Jan 2022, at 15:23, Romain Beauxis wrote:
This patch switches the logic around audio settings to let the caller
drive the format.
Hi,
just a quick technical feedback, with the patch sent as attachment it
now finally applies
fine for me, thanks!
After experimenting with the AudioConverter, we realized that, even
when adhering to a strict implementation of the documented API, we
were still getting errors during conversions. The input device would
randomly change from e.g. s32le to s24le between restarts and error
out on conversion (using a freshly initialized converter).
Using setAudioSettings allow the OS to drive audio conversion
internally and pick whatever appropriate settings for the audio
device. This has been working very well and is also the way
AVFoundation audio input is setup in videolan.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
