Michael Niedermayer:
> Signed-off-by: Michael Niedermayer <mich...@niedermayer.cc>
> ---
> libavcodec/movtextdec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/movtextdec.c b/libavcodec/movtextdec.c
> index 825632ca9b..dc30fdc698 100644
> --- a/libavcodec/movtextdec.c
> +++ b/libavcodec/movtextdec.c
> @@ -263,7 +263,7 @@ static int decode_hclr(const uint8_t *tsmb,
> MovTextContext *m, uint64_t size)
>
> static int styles_equivalent(const StyleBox *a, const StyleBox *b)
> {
> -#define CMP(field) a->field == b->field
> +#define CMP(field) ((a)->field == (b)->field)
> return CMP(bold) && CMP(italic) && CMP(underline) && CMP(color) &&
> CMP(alpha) && CMP(fontsize) && CMP(font_id);
> #undef CMP
LGTM.
(Did you find the issues in patches 2-4 by code inspection or by a
static analyzer?)
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
