>1. Options of type AV_OPT_TYPE_INT need to have a target of type int. >2. Setting UINT_MAX as maximum for such an option is nonsense; INT_MAX is the >maximum for it. (FFMIN(INT_MAX, SIZE_MAX) would be even better.) 3. Allowing >zero for fifo_size_limit makes no sense, as the above code allocates 16 >when >allocating the FIFO. >4. After removing av_fifo_grow2() it is no longer assured that >av_fifo_write() succeeds; it therefore needs to be checked. > >- Andreas
Fixed in v4. Thanks (I have revised the spliting between the 2 patches). Nicolas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
