> On Apr 7, 2022, at 4:42 PM, Eran Kornblau <eran.kornb...@kaltura.com> wrote: > >> >> >> -----Original Message----- >> From: ffmpeg-devel <ffmpeg-devel-boun...@ffmpeg.org> On Behalf Of >> "zhilizhao(???)" >> Sent: Wednesday, 6 April 2022 11:46 >> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> >> Subject: Re: [FFmpeg-devel] movenc: add write_btrt option >>> >>> supports forcing or disabling the writing of the btrt atom. >>> the default behavior is to write the atom only for mp4 mode. >>> --- >>> libavformat/movenc.c | 30 +++++++++++++++++++----------- >>> libavformat/movenc.h | 1 + >>> 2 files changed, 20 insertions(+), 11 deletions(-) >>> >> >> I prefer to handle the auto mode (mov->write_btrt == -1) in a single place, >> so we don’t need to change multiple lines if the condition changed, e.g., >> enable btrt for MODE_MOV. Please correct me if I’m wrong, mov_init() has all >> of the contexts to overwrite mov->write_btrt. >> > Makes sense, thanks for the feedback! > Updated patch attached
LGTM. > > Eran > <0001-movenc-add-write_btrt-option.patch>_______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
