On 20/05/2022 12:39, Soft Works wrote:
-----Original Message-----
From: ffmpeg-devel <ffmpeg-devel-boun...@ffmpeg.org> On Behalf Of Timo
Rothenpieler
Sent: Friday, May 20, 2022 12:18 PM
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libx264: don't define
X264_API_IMPORTS when compiling static
On 20/05/2022 00:52, softworkz wrote:
From: softworkz <softwo...@hotmail.com>
The definition of X264_API_IMPORTS is required for shared linking
(when MSVC is used) but it must not be defined in case of static
builds as is stated in x264.h:
This doesn't seem right. It's about shared or static linking of
libx264
itself, not ffmpeg.
How about some custom macro like DISABLE_X264_API_IMPORTS that one
can set when desired?
In that case there wouldn't be any logical irritation.
I'm still quite confused what the actual issue here is.
Countless libraries ffmpeg depends on need those kind of macros to set
the correct function import preamble.
Why does x264 need special treatment? It correctly sets the desired flag
via its pkg-config file.
Is this some "pkg-config does not exist with msvc" thing?
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
