ping again!

Are there any objections to this patch set?
If not, would someone push it to the repository?

On 2022/06/08 18:48, TADANO Tokumei wrote:
ping

The patch set has been well tested by Japanese ISDB-related developers and 
works fine.
I think it already has good quality to merge.

It requires external library like libaribb24, but the feature is disabled by 
default.
There is no impact to current code without `--enable-libaribcaption` option is
specified at configuration. The patch set provide better subtitle feature
for ISDB users than libaribb24 if enabled.

On 2022/05/30 23:55, TADANO Tokumei wrote:
This patch set add another ARIB caption decoder using libaribcaption
external library: https://github.com/xqq/libaribcaption
The library decodes subtitles of ISDB-based TV broadcasting.
It is not only for Japanese ARIB STD-B24 caption, but also for
Brazilian ABNT NBR 15606-1 and Philippines version of ISDB-T.

Unlike libaribb24, it supports 3 types of subtitle outputs:
* text: plain text
* ass: ASS formatted text
* bitmap: bitmap image

Default subtitle type is ASS as same as libaribb24, but it can
be changed by `-sub_type` option.
You can see ARIB caption with ffplay tool:
   ffplay -sub_type bitmap MPEG.TS

Sample files exist under:
   https://streams.videolan.org/streams/ts/ARIB/
Some of them are encrypted and some don't contain ARIB caption data.
Good samples for ARIB caption are:
   brazil/07-25_20-33-35_UCV - HD_.ts
   japan/channel2[137]_clear.ts

---
v4: reflect review results from outside of this ML.
   - resize bitmap subtitle image to display fonts with correct aspect ratio
   - multiple font families can be specified by '-font' option
   - remove 'rendering_backend' option
   - add document
   - minor bug fixes
v3: combine former 1/4 and 2/4 due to the patchwork shows build error.
v2: combine former 1/5 and 2/5 due to the patchwork shows build error.
   - fix help option content which incorrectly separated to 2 lines in 2/4.
   - amend commit message of 4/4.

TADANO Tokumei (4):
   lavc/libaribcaption.c: add ARIB caption decoder using libaribcaption
   lavc/codec_desc.c: remove AV_CODEC_PROP_TEXT_SUB property
   lavf/mpegts.c: set some properties for ARIB caption
   doc/decoders.texi: add document of aribcaption decoder

  configure                   |    4 +
  doc/decoders.texi           |   99 +++
  libavcodec/Makefile         |    1 +
  libavcodec/allcodecs.c      |    1 +
  libavcodec/codec_desc.c     |    1 -
  libavcodec/libaribb24.c     |    1 +
  libavcodec/libaribcaption.c | 1137 +++++++++++++++++++++++++++++++++++
  libavformat/mpegts.c        |   19 +-
  8 files changed, 1261 insertions(+), 2 deletions(-)
  create mode 100644 libavcodec/libaribcaption.c

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Reply via email to