On Thu, May 21, 2015 at 12:31:21PM +0800, Zhang Rui wrote: > Discontinuous sample could cause corrupted image if next video frame > is non-key frame. > > Mostly, avio_seek() fails on I/O error for http/ftp/... stream. > In my opinion, retry is better than skip. > > > - /* must be done just before reading, to avoid infinite loop on sample > > */ > > - sc->current_sample++; > > This line was first introduced in 2006 by commit b72708f8f. > I'm not sure if it worth an option to enable the new behaviour, > and keep the default behaviour as before.
if its specific to avio_seek() should current_sample-- be done in its error case instead ? maybe with a retry count to limit retries in case the next sample can be read but the current always fails Iam not sure i fully understand the bug this fixes, how can it be reproduced ? [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Dictatorship naturally arises out of democracy, and the most aggravated form of tyranny and slavery out of the most extreme liberty. -- Plato
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
