On Mon, 26 Dec 2022, Michael Niedermayer wrote:
On Mon, Dec 26, 2022 at 11:32:48AM +0100, Tomas Härdin wrote:
lör 2022-12-24 klockan 23:50 +0100 skrev Michael Niedermayer:
index_table->nb_ptses += s->index_duration;
+ // If index_duration is substantially larger than
nb_index_entries then this algorithm which
+ // allocates index_duration elements is a bad idea. All
files i tried have it equal
+ if (s->index_duration > 10LL * s->nb_index_entries)
+ return AVERROR_PATCHWELCOME;
I was going to say this can overflow but the 10LL ensures it can't. So
looks OK.
will apply
Please don't, as far as I see this disallows the usage of partial index
tables, so practically rejecting valid files, which is not OK.
Regards,
Marton
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
