On Fri, 24 Feb 2023, xufuji456 wrote:

---
libavcodec/aarch64/hevcdsp_idct_neon.S    | 40 +++++++++++++++++++++++
libavcodec/aarch64/hevcdsp_init_aarch64.c |  4 +++
2 files changed, 44 insertions(+)

Thanks, this looks good to me now, will push in a moment.

The subject of the commit doesn't need to include "after fixed" or such comments - those comments are kinda irrelevant once the commit gets pushed.

It's usually good practice to include checkasm benchmark numbers (and mention what system the numbers are from) when posting assembly optimizations.

// Martin

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Reply via email to