Thanks for the feedback. I thought across libraries meant across different muxers/demuxers. In which case, is there any naming scheme for functions that are only used within lavf? Can i just remove the avpriv_ prefix?
For inline, my habit is to add it when there’s only one place that uses it. I can remove it. I will make changes to other parts. On Mon, May 1, 2023 at 00:14 Anton Khirnov <an...@khirnov.net> wrote: > Quoting SuperFashi (2023-04-30 05:32:46) > > Thanks. Is there anything else that does not fit codebase tradition? > Please > > point everything out so I could send a new patch. > > Some quick notes: > * why are there avpriv_ functions when everything you do is libavformat? > avpriv is for sharing functions across libraries > * header order (first system, then ours, sort each of those > alphabetically) > * opening brace for function declarations should be on its own line > * very long lines everywhere; we have a soft limit of 80 characters (can > be exceeded where really needed, but should be done sparingly) > if your code needs more then it's a sign that you have too much > indentation or your names are too long > * inline specifiers all over the place, I think modern compilers largely > ignore them; even if they didn't it's better to leave such decisions > to compilers in most cases > > -- > Anton Khirnov > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".