On date Tuesday 2023-09-05 12:43:35 +0000, ffmpeg-devel Mailing List wrote: [...] > On date Saturday 2023-09-02 09:20:08 +0000, Carotti, Elias wrote: > > On Thu, 2023-08-31 at 19:09 +0200, Stefano Sabatini wrote: > > > > > <snip> > > > > > > > In particular why are you turning on fast_pskip silently based on > > > > a completely different setting? > > > > > > The patch is fixing the regression introduced by the unconditional > > > setting of b_fast_pskip. > > > > > > Now the question is if it makes sense to set mb_info without > > > b_fast_pskip (in both case this should be probably documented). > > > > > > @Elias can you comment about the mb_info/b_fast_pskip use case? > > > > Sorry again for the delay in responding. > > We can safely remove it altogether. It's true we don't need to set it > > along with mb_info. > > However, it doesn't do any harm, since fast_pskip is by default set to > > true by libx264 and only turned off either explicitly by the user, or > > when using the placebo preset, or when doing lossless encoding > > (constant QP == 0.) So, I agree, let's remove these three lines. > > > > Thanks, updated. > > Ok for me
Applied, thanks. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".